Fix build break in System.Net.Security TestConfiguration after OpenBSD port (#129479)#129587
Closed
lewing wants to merge 1 commit into
Closed
Fix build break in System.Net.Security TestConfiguration after OpenBSD port (#129479)#129587lewing wants to merge 1 commit into
lewing wants to merge 1 commit into
Conversation
PR dotnet#129479 (Port System.Net.Security to OpenBSD) added RuntimeInformation.IsOSPlatform(OSPlatform.Create("OPENBSD")) calls to TestConfiguration.cs without adding the using directive for System.Runtime.InteropServices, breaking the build on main and on every open PR with CS0103 'RuntimeInformation' / 'OSPlatform' does not exist. Add the missing using directive to unblock CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a build break in System.Net.Security functional tests by restoring the missing System.Runtime.InteropServices using needed for RuntimeInformation / OSPlatform references in TestConfiguration.
Changes:
- Add
using System.Runtime.InteropServices;toTestConfiguration.csso OpenBSD platform checks compile.
pavelsavara
approved these changes
Jun 18, 2026
Member
|
Dup of #129579. |
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #129479 (Port System.Net.Security to OpenBSD) merged to
mainon 2026-06-18 and reintroduced uses ofRuntimeInformation.IsOSPlatform(OSPlatform.Create("OPENBSD"))insrc/libraries/System.Net.Security/tests/FunctionalTests/TestConfiguration.cs(lines 29-30) without adding the correspondingusing System.Runtime.InteropServices;directive.The
usinghad been removed previously because #124555 (Remove Windows 7 support code from System.Net.Security) had cleaned up the only references that needed it.As a result,
mainHEAD currently fails to build with:This breaks every open PR's CI as soon as it merges in the latest
main(e.g. observed on the codeflow PR #129454 across 21 build legs).#129479's own CI had these same 4 errors prior to merge (build 1467260), but the PR was admin-merged.
Fix
Add
using System.Runtime.InteropServices;toTestConfiguration.cs. One-line fix.Note
This comment was AI/Copilot-generated.