Skip to content

Disable AVX/AVX2 on interpreter-only x64 builds to fix Vector256 NRE #129574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kotlarmilos wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Disable AVX/AVX2 on interpreter-only x64 builds to fix Vector256 NRE #129574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/coreclr/vm/codeman.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1793,6 +1793,18 @@ void EEJitManager::SetCpuInfo()
}
#endif

#if defined(FEATURE_INTERPRETER) && (defined(TARGET_X86) || defined(TARGET_AMD64))
if (interpreterOnly)
{
// The interpreter only supports 128-bit vectors, so clear AVX to let the
// dependency resolution below cascade-remove AVX2, AVX512, Vector256 and Vector512
// while keeping Vector128 and X86Base, matching the x86-64-v2 ReadyToRun baseline
// used for these targets so the reported ISA stays in sync with R2R and the
// 128-bit path is taken.
Comment thread
kotlarmilos marked this conversation as resolved.
CPUCompileFlags.Clear(InstructionSet_AVX);
}
#endif

// These calls are very important as it ensures the flags are consistent with any
// removals specified above. This includes removing corresponding 64-bit ISAs
// and any other implications such as SSE2 depending on SSE or AdvSimd on ArmBase
Expand Down
Loading