Skip to content

Limit osx-x64 CoreCLR_Libraries PR builds#129542

Open
davidwrighton wants to merge 1 commit into
dotnet:mainfrom
davidwrighton:dwrighton/osx-x64-coreclr-libs-condition
Open

Limit osx-x64 CoreCLR_Libraries PR builds#129542
davidwrighton wants to merge 1 commit into
dotnet:mainfrom
davidwrighton:dwrighton/osx-x64-coreclr-libs-condition

Conversation

@davidwrighton

Copy link
Copy Markdown
Member

Summary

  • limit the osx-x64 release CoreCLR_Libraries PR build to installer-related changes
  • keep the build running for non-PR rolling builds

Context

The osx-x64 release CoreCLR_Libraries build exists for the osx-x64 installer build/test dependency path, so PR builds only need it when installer tests can run.

Note

This PR description was created by GitHub Copilot.

Only run the osx-x64 release CoreCLR_Libraries build for installer PR changes, since its PR dependency path is the osx-x64 installer build/test job. Keep the build enabled for rolling runs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This change updates the main runtime Azure Pipelines definition to further gate the osx-x64 CoreCLR_Libraries (Release) PR build so it only runs when the PR touches paths categorized as installer-relevant (while still running on all non-PR builds via isRollingBuild).

Changes:

  • Tightened the condition: for the osx-x64 Release CoreCLR_Libraries build to use SetPathVars_installer.containsChange instead of SetPathVars_non_mono_and_wasm / SetPathVars_libraries.
  • Kept the non-PR behavior unchanged by retaining the or(..., eq(variables['isRollingBuild'], true)) clause.

@am11

am11 commented Jun 18, 2026

Copy link
Copy Markdown
Member

Upcoming macOS 27 (Golden Gate) is dropping intel macs support which they retired in 2020 and last batch manufactured in 2023. Maybe we should stop treating osx-x64 as "more important" than osx-arm64. (in this CI run, e.g., we have 26 hits for osx-x64 and 22 for osx-arm64).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants