[release/8.0-staging] Fix assembly labels on MacOS X64 to be LOCAL_LABEL#129534
Open
davidwrighton wants to merge 1 commit into
Open
[release/8.0-staging] Fix assembly labels on MacOS X64 to be LOCAL_LABEL#129534davidwrighton wants to merge 1 commit into
davidwrighton wants to merge 1 commit into
Conversation
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports a fix to the CoreCLR AMD64 virtual call stub assembly to ensure internal branch targets use platform-appropriate local label naming on macOS x64, preventing the linker from carving the function into incorrect subsections.
Changes:
- Converted several internal labels and branch targets in
ResolveWorkerChainLookupAsmStubto useLOCAL_LABEL(...). - Ensured loop, success, promote, and fail labels are all emitted as local labels (and referenced consistently) to avoid macOS linker symbol/subsection issues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Not doing this leads to the functions being carved up by the linker, which leads to incorrect behavior. (cherry picked from commit e09733c)
davidwrighton
changed the title
davidwrighton
force-pushed
the
backport/129531-net8
branch
from
abd2e3c to
a11bcfb
Compare
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #129531 to release/8.0-staging.
/cc @davidwrighton
Customer Impact
Without this fix, macOS x64 assembly labels can be emitted as ordinary symbols instead of local labels. That can let the linker carve up functions incorrectly, leading to incorrect runtime behavior.
Regression
No known recent regression; this fixes existing assembly label authoring for macOS x64.
Testing
This backport only changes
src/coreclr/vm/amd64/virtualcallstubamd64.SbecauseContext.Sis not present on .NET 8. No new test was added because this is an assembly-label/linker-behavior fix. The source PR and this backport PR rely on CI coverage for the affected release branch.Risk
Low. The change is limited to converting internal assembly labels and branches to LOCAL_LABEL(...) in macOS x64 CoreCLR assembly code, preserving control flow while avoiding externally visible labels.
IMPORTANT: If this backport is for a servicing release, please verify that:
elease/X.0-staging, not
elease/X.0.
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Note
This PR description was generated by GitHub Copilot.