Skip to content

Port System.Diagnostics.Process to OpenBSD#129470

Open
sethjackson wants to merge 6 commits into
dotnet:mainfrom
sethjackson:port-sdp-openbsd
Open

Port System.Diagnostics.Process to OpenBSD#129470
sethjackson wants to merge 6 commits into
dotnet:mainfrom
sethjackson:port-sdp-openbsd

Conversation

@sethjackson

@sethjackson sethjackson commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Port System.Diagnostics.Process to OpenBSD. Contributes to #124911.

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 16, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

@sethjackson

Copy link
Copy Markdown
Contributor Author

@am11 FYI this is a WIP

@am11

am11 commented Jun 17, 2026

Copy link
Copy Markdown
Member

@sethjackson, with sethjackson#2, all test failures are gone:

am11@foo:~/system.diag.proc$ ./RunTests.sh --runtime-path ~/th/artifacts/bin/testhost/net11.0-openbsd-Debug-x64
...
  Discovering: System.Diagnostics.Process.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Diagnostics.Process.Tests (found 382 of 464 test cases)
  Starting:    System.Diagnostics.Process.Tests (parallel test collections = on [5 threads], stop on fail = off)
.ProcessO    System.Diagnostics.Tests.ProcessStartInfoTests.ShellExecute_Nano_Fails_Start [SKIP]
      Condition(s) not met: "IsWindowsNanoServer"
OpenBSD
    System.Diagnostics.Tests.ProcessTests.TestBasePriorityOnUnix [SKIP]
      Condition(s) not met: "IsPrivilegedProcess"
    System.Diagnostics.Tests.ProcessTests.TestPriorityClassUnix [SKIP]
      Condition(s) not met: "IsPrivilegedProcess"
    System.Diagnostics.Tests.ProcessTests.TestProcessRecycledPid [SKIP]
      Condition(s) not met: "IsStressModeEnabledAndRemoteExecutorSupported"
    System.Diagnostics.Tests.ProcessTests.TestCheckChildProcessUserAndGroupIdsElevated [SKIP]
      Condition(s) not met: "IsRemoteExecutorSupportedAndPrivilegedProcess"
    System.Diagnostics.Tests.ProcessOpenTests.Open_ProtectedProcess_ThrowsUnauthorizedAccessException [SKIP]
      Condition(s) not met: "IsWindows"
  Finished:    System.Diagnostics.Process.Tests
=== TEST EXECUTION SUMMARY ===
   System.Diagnostics.Process.Tests  Total: 598, Errors: 0, Failed: 0, Skipped: 6, Time: 745.677s
~/system.diag.proc

Implement missing parts of S.D.Process for OpenBSD
@sethjackson sethjackson marked this pull request as ready for review June 17, 2026 20:59
@sethjackson

Copy link
Copy Markdown
Contributor Author

Awesome! Thanks! I merged it.

@am11 am11 requested review from adamsitnik, janvorli and wfurt June 17, 2026 21:04
@am11

am11 commented Jun 17, 2026

Copy link
Copy Markdown
Member

@janvorli, @adamsitnik, @wfurt, some code is shared with BSD/FreeBSD, rest is mostly definitions and OpenBSD specific mechanisms (what it lacks and provided alternatives).

@am11 am11 closed this Jun 18, 2026
@am11 am11 reopened this Jun 18, 2026
@am11

am11 commented Jun 18, 2026

Copy link
Copy Markdown
Member

Closed/reopened to kick the build again. WithPackages leg failed because of versioning.targets is missing OpenBSD which is now merged to main (CI merges main to branch before running build so this approach works).

@sethjackson

Copy link
Copy Markdown
Contributor Author

Closed/reopened to kick the build again. WithPackages leg failed because of versioning.targets is missing OpenBSD which is now merged to main (CI merges main to branch before running build so this approach works).

I can also merge main if that is preferable.

@am11

am11 commented Jun 18, 2026

Copy link
Copy Markdown
Member

I can also merge main if that is preferable.

Yes, feel free. :)

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Diagnostics.Process community-contribution Indicates that the PR has been added by a community member os-openbsd OpenBSD OS, currently not officially supported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants