Skip to content

Port System.Net.Security to OpenBSD#129479

Merged
rzikm merged 5 commits into
dotnet:mainfrom
am11:patch-54
Jun 18, 2026
Merged

Port System.Net.Security to OpenBSD#129479
rzikm merged 5 commits into
dotnet:mainfrom
am11:patch-54

Conversation

@am11

@am11 am11 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Contributes to #124911.

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 16, 2026
@am11

am11 commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

@sethjackson, unit tests with this change:

/home/am11/th/artifacts/bin/testhost/net11.0-openbsd-Debug-x64/dotnet exec --runtimeconfig System.Net.Security.Unit.Tests.runtimeconfig.json --depsfile System.Net.Security.Unit.Tests.deps.json xunit.console.dll System.Net.Security.Unit.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
popd
===========================================================================================================
~/system.netsec ~/system.netsec
  Discovering: System.Net.Security.Unit.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Security.Unit.Tests (found 83 of 86 test cases)
  Starting:    System.Net.Security.Unit.Tests (parallel test collections = on [5 threads], stop on fail = off)
    System.Net.Security.Tests.NegotiateAuthenticationTests.Package_Unsupported_NTLM [SKIP]
      Condition(s) not met: "IsNtlmUnavailable"
    System.Net.Security.Tests.NegotiateAuthenticationTests.NtlmMalformedChallenge_ReturnsInvalidToken [SKIP]
      Condition(s) not met: "UseManagedNtlm"
    System.Net.Security.Tests.NegotiateAuthenticationTests.NtlmWithPreExistingTargetInfoEntriesTest [SKIP]
      Condition(s) not met: "UseManagedNtlm"
  Finished:    System.Net.Security.Unit.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Security.Unit.Tests  Total: 114, Errors: 0, Failed: 0, Skipped: 3, Time: 5.449s
~/system.netsec

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@sethjackson

Copy link
Copy Markdown
Contributor

Nice! Seems you fixed the test failures I was having and makes sense as I didn't do the opt-in to managed NTLM. 💯

@am11 am11 added the os-openbsd OpenBSD OS, currently not officially supported label Jun 16, 2026
@am11 am11 requested review from janvorli, rzikm and wfurt June 16, 2026 21:17

@rzikm rzikm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm

rzikm commented Jun 18, 2026

Copy link
Copy Markdown
Member

/ba-g Test failures are unrelated

@rzikm rzikm merged commit 4796c4f into dotnet:main Jun 18, 2026
126 of 147 checks passed
@am11 am11 deleted the patch-54 branch June 18, 2026 12:54
@vcsjones

Copy link
Copy Markdown
Member

This looks like it broke the build. it's odd that Helix did not surface the compilation errors. If I dig in the logs, they are there though https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/build/builds/1467260/logs/1003

2026-06-16T22:57:34.0038203Z D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\TestConfiguration.cs(29,158): error CS0103: The name 'RuntimeInformation' does not exist in the current context [D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj::TargetFramework=net11.0-windows]
2026-06-16T22:57:34.0052636Z D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\TestConfiguration.cs(29,190): error CS0103: The name 'OSPlatform' does not exist in the current context [D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj::TargetFramework=net11.0-windows]
2026-06-16T22:57:34.0054981Z D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\TestConfiguration.cs(30,158): error CS0103: The name 'RuntimeInformation' does not exist in the current context [D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj::TargetFramework=net11.0-windows]
2026-06-16T22:57:34.0056051Z D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\TestConfiguration.cs(30,190): error CS0103: The name 'OSPlatform' does not exist in the current context [D:\a\_work\1\s\src\libraries\System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj::TargetFramework=net11.0-windows]

@am11

am11 commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Fix in #129579. I was gathering changes from a shared branch missed it.

it's odd that Helix did not surface the compilation errors.

Perhaps this false-negative is interesting for @dotnet/dnceng.

@lewing

lewing commented Jun 18, 2026

Copy link
Copy Markdown
Member

/ba-g Test failures are unrelated

Nope #129587

@am11

am11 commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

@lewing, read the comment above yours.

lewing pushed a commit that referenced this pull request Jun 18, 2026
Without this change there's error:

```
/home/runtime/src/libraries/System.Net.Security/tests/FunctionalTests/TestConfiguration.cs(29,158): error CS0103: The name 'RuntimeInformation' does not exist in the current context [/home/runtime/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj::TargetFramework=net11.0-unix]
```

This is introduced in #129479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Net.Security community-contribution Indicates that the PR has been added by a community member os-openbsd OpenBSD OS, currently not officially supported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants