Add analyzer 'Unnecessary null coalescing' - #1826
Open
josefpihrt wants to merge 3 commits into
Open
Conversation
Flag ?? and ??= when nullable flow analysis shows the left operand is never null. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace embedded coalesce-assignment statements with an empty block so the fix stays valid inside if/while/for. Drop the implicit-new skip that RCS1143 does not cover, and restore the unrelated config URL change. Co-authored-by: Cursor <cursoragent@cursor.com>
Register only on C# 8+ and return before GetTypeInfo unless GetNullableContext reports AnnotationsEnabled at the node. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
??and??=when nullable flow analysis shows the left operand is a never-null reference type.??=, or replaces an expression-level??=with the left side.this,new, constants) and skip nested??that would conflict with FixAll.Test plan
dotnet testfilterFullyQualifiedName~RCS1269#nullable enablesamples from the issue (errors ?? [],_context ??= ..., property??=)string?, and for RCS1143 overlap ("" ?? "a",this ?? x)Related issue
Fixes #1658
Made with Cursor