Escalate repo-enforced code style diagnostics to warning - #1816
Open
josefpihrt wants to merge 6 commits into
Open
Escalate repo-enforced code style diagnostics to warning#1816josefpihrt wants to merge 6 commits into
josefpihrt wants to merge 6 commits into
Conversation
Make listed RCS rules and CI format checks fail at warning severity so contributors see style issues during local builds under TreatWarningsAsErrors. Co-authored-by: Cursor <cursoragent@cursor.com>
Local dotnet format and CI disagree on indentation around #endif for ROSLYN_* defines; keep the layout CI expects. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep RCS9001 at suggestion (existing pattern-matching debt) and add ConfigureAwait(false) in the roslyn3.8 path of RawStringLiteralCodeFixProvider. Co-authored-by: Cursor <cursoragent@cursor.com>
Use an explicit SHA256 type under NETFRAMEWORK so TreatWarningsAsErrors succeeds on Windows framework CLI builds. Co-authored-by: Cursor <cursoragent@cursor.com>
Add explicit warning entries for product-default Info rules that were still at suggestion, so TreatWarningsAsErrors and format --severity warn enforce them. Leave RCS1163, RCS1213, and RCS9001 at suggestion due to multi-Roslyn TFM / #if debt. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.editorconfigfromsuggestiontowarning, and setcsharp_style_namespace_declarationsto warning, so style issues fail local/CI builds underTreatWarningsAsErrors.Infoanalyzers towarningin.editorconfig(exceptRCS1163,RCS1213,RCS9001, left atsuggestionfor multi-Roslyn TFM /#ifdebt).dotnet formatin CI and agent skills from--severity infoto--severity warn.ConfigureAwait(false)on roslyn3.8 path; explicitSHA256type underNETFRAMEWORK.Test plan
cd src && dotnet build Roslynator.slnwithTreatWarningsAsErrors=truecd src && dotnet format Roslynator.sln --no-restore --verify-no-changes --severity warnroslyn3.8/roslyn4.7) withTreatWarningsAsErrors