[WIP][iOS & Mac] Fix NullReferenceException in CollectionViewHandler2 after handler restore when property changes#36073
Draft
SubhikshaSf4851 wants to merge 1 commit into
Draft
Conversation
…r handler restore when ItemsLayout property changes
SubhikshaSf4851
had a problem deploying
to
gh-aw-agents
GitHub Actions
Failure
SubhikshaSf4851
temporarily deployed
to
gh-aw-agents
GitHub Actions
Inactive
Tamilarasan-Paranthaman
added
platform/macos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment whether this change resolves your issue. Thank you!
This pull request addresses a regression issue where
CollectionViewHandler2could throw aNullReferenceExceptionif a layout property changed after the handler was disconnected and then reconnected. The fix ensures the internal cache is properly reinitialized, and new tests are added to verify the handler's stability in these scenarios.Description of Change
Bug fix:
_layoutPropertyCacheis reinitialized when subscribing to a new items layout inCollectionViewHandler2, preventingNullReferenceExceptionafter handler disconnect/reconnect cycles.Testing improvements:
GridItemsLayoutandLinearItemsLayoutafter a disconnect/restore cycle does not cause crashes inCollectionViewHandler2. These tests cover various property changes and validate the fixIssues Fixed
Fixes #36010
Tested the behavior in the following platforms