Fix failing "repository_lockdown" CI job by updating actions/github-script to v7#19812
Fix failing "repository_lockdown" CI job by updating actions/github-script to v7#19812T-Gro wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
left a comment
There was a problem hiding this comment.
LGTM – clean revert of the workaround now that Roslyn handles the diagnostics correctly. The ExceptWith logic is the right way to deduplicate, and the new tests cover the key scenarios well.
Two minor suggestions (non-blocking):
-
Rename the HACK methods: Now that the workaround is gone, the TODO comments explaining the HACK names were removed, but the method names still carry the
_HACK_PLEASE_REFER_TO_COMMENT_INSIDEsuffix. Consider renaming them back to their original names (e.g.VerifyDiagnosticBetweenMarkers,VerifyErrorBetweenMarkers,VerifyErrorAtMarker) since the hack is no longer needed. -
Warning not duplicated across passes test: The source
let x = 42at module level doesn't produce any warnings (it's a public binding), soallWarningsis always empty and the assertion trivially passes. Consider using source that actually emits a warning (e.g.open Systemwithout using anything from it, or a private unused binding) to make the test meaningful.
❗ Release notes required
Warning No PR link found in some release notes, please consider adding it.
|
…own_check.yml Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
The
repository_lockdownCI job was failing becauseactions/github-script@v6resolved to a SHA (d7906e4ad0b1822421a7e6a35d5ca353c962f410) that is no longer available on GitHub's CDN, causing a 404 when the runner tried to download the action archive.Updated all three usages of
actions/github-script@v6toactions/github-script@v7in.github/workflows/repository_lockdown_check.yml. Thev7release is currently available and maintains the same API surface used by the workflow scripts.