Improve AnchorMode_End_LargeAppendAtBottom_StillFollows#67639
Open
ilonatommy wants to merge 2 commits into
Open
Improve AnchorMode_End_LargeAppendAtBottom_StillFollows#67639ilonatommy wants to merge 2 commits into
AnchorMode_End_LargeAppendAtBottom_StillFollows#67639ilonatommy wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Blazor virtualization E2E coverage to ensure the AnchorMode_End_LargeAppendAtBottom_StillFollows test actually validates End-mode auto-follow behavior after a large append, rather than forcing the scroll position in the assertion loop.
Changes:
- Removed the test’s manual
scrollTop = scrollHeightassignment from the polling assertion so it no longer “makes itself pass.” - Strengthened the scenario by additionally asserting that real items near the new end of the list (not provider placeholders) are materialized after the append.
Last row of 1k item 0-indexed list, after appending 100 items is 1099, not 1090.
dariatiurina
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
AnchorMode_End_LargeAppendAtBottom_StillFollowsE2E test did not actually verify auto-follow behavior. Its assertion re-scrolled the container to the bottom inside the polling loop.Because the test itself performed the scroll-to-bottom that the engine is supposed to do on append, the assertion would be always true, whether or not End-mode auto-follow worked. It provided no real regression coverage for the "append at bottom keeps following" behavior it was named for.
The scenario works correctly, I tested it manually. Only the test's logic needs the "manual" scroll removal.
end-large-append.mp4