Skip to content

Improve AnchorMode_End_LargeAppendAtBottom_StillFollows#67639

Open
ilonatommy wants to merge 2 commits into
mainfrom
virtualize-fix-big-append-test-logic
Open

Improve AnchorMode_End_LargeAppendAtBottom_StillFollows#67639
ilonatommy wants to merge 2 commits into
mainfrom
virtualize-fix-big-append-test-logic

Conversation

@ilonatommy

@ilonatommy ilonatommy commented Jul 7, 2026

Copy link
Copy Markdown
Member

The existing AnchorMode_End_LargeAppendAtBottom_StillFollows E2E test did not actually verify auto-follow behavior. Its assertion re-scrolled the container to the bottom inside the polling loop.

Because the test itself performed the scroll-to-bottom that the engine is supposed to do on append, the assertion would be always true, whether or not End-mode auto-follow worked. It provided no real regression coverage for the "append at bottom keeps following" behavior it was named for.

The scenario works correctly, I tested it manually. Only the test's logic needs the "manual" scroll removal.

end-large-append.mp4

@ilonatommy ilonatommy added this to the 11.0-preview7 milestone Jul 7, 2026
@ilonatommy ilonatommy self-assigned this Jul 7, 2026
@ilonatommy ilonatommy requested a review from a team as a code owner July 7, 2026 15:11
Copilot AI review requested due to automatic review settings July 7, 2026 15:11
@ilonatommy ilonatommy added area-blazor Includes: Blazor, Razor Components feature-blazor-virtualization This issue is related to the Blazor Virtualize component labels Jul 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Blazor virtualization E2E coverage to ensure the AnchorMode_End_LargeAppendAtBottom_StillFollows test actually validates End-mode auto-follow behavior after a large append, rather than forcing the scroll position in the assertion loop.

Changes:

  • Removed the test’s manual scrollTop = scrollHeight assignment from the polling assertion so it no longer “makes itself pass.”
  • Strengthened the scenario by additionally asserting that real items near the new end of the list (not provider placeholders) are materialized after the append.

Last row of 1k item 0-indexed list, after appending 100 items is 1099, not 1090.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components feature-blazor-virtualization This issue is related to the Blazor Virtualize component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants