[Blazor] Preserve null values for <option value="@null"> in single select binding#67616
Open
Yuvan111 wants to merge 5 commits into
Open
[Blazor] Preserve null values for <option value="@null"> in single select binding#67616Yuvan111 wants to merge 5 commits into
Yuvan111 wants to merge 5 commits into
Conversation
Contributor
|
Thanks for your PR, @Yuvan111. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Blazor] Preserve null values for in single select binding
Description
<option value="@null">now binds to anullvalue on a single<select>, instead of being treated as an empty string. The DOM cannot represent a null<option>value, so we render the value as an empty string and add a small marker attribute that the change handler recognizes. The result is reported to .NET asnull, so a nullable bound property receivesnulldirectly no manual conversion from""is needed.Html Output:
Scope and limitations
<select>only. Multi-select is not supported in this change, because the array of selected values is delivered as a plainstring[]and cannot carrynullentries end-to-end.<option value="">and<option value="@null">in the same<select>. They render identically in the DOM (both asvalue=""); only the marker-bearing option is reported asnullon the change event. The empty-string option will arrive as"". This is by design the two options are indistinguishable to the user and to the DOM, but only the marker option carries the null meaning back to .NET.string?. Binding to a non-nullablestringwill receivenulland surface a runtime error, as expected.<select>without<option value="@null">continues to report the element's value exactly as before, including the""returned when nothing is selected.Fixes #23934