ASCII-Blockkopf-Dekoder, 1326–1333 Umbenennung, 20xx/21xx auf Read#89
Merged
dosordie merged 1 commit intoJul 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
0x00/0xFFoder anderen nicht-druckbaren Bytes enthält.Description
MainWindow._decode_printable_ascii_wordinfoxair_phnix_control.pyauf byteweise Prüfung, wobei0x00und0xFFsowie nicht-druckbare Bytes ignoriert werden und druckbare ASCII-Zeichen erhalten bleiben; die Fall‑Back-AusgabeReservebleibt erhalten, wenn kein Zeichen übrig bleibt.Rücklaufpumpe→Zirkulationspumpefür die Register1326–1333indata/foxair_phnix_registers.jsonund passt die Erwähnung indocs/public/README.txtan.mode-Felder vonwrite/r/waufread/read-only, sodass Status/Diagnose-/Zählerwerte nicht als schreibbar erscheinen (Änderungen nur Bezeichnung/Mode, keine Logik).foxair_phnix_control.py,data/foxair_phnix_registers.json,docs/public/README.txt.Testing
python -m compileall .wurde ausgeführt und war erfolgreich.PYTHONPATH=. pytestlief erfolgreich und ergab16 passed, 2 skipped.0x6135 -> 'a5',0x7800 -> 'x', gesamter beobachteter 200er-HMI-Blocka5c6utQfC8x) sowie die Register-Umbenennung und dass keine 20xx/21xx-Einträge mehrmode: writehaben, und lief erfolgreich.Codex Task