Improve Display-Modbus init progress#82
Merged
dosordie merged 1 commit intoJun 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DisplayKnownReadController._progress,_busy,_finished,_failedand wired them at key points (prepared, worker start, trigger/send, wait, response, retry rounds, timeouts) inworkers/display_worker.pyto report Display-Modbus steps.display_init_progress_changed,display_init_progress_busy,display_init_progress_finished,display_init_progress_failedand adjusted_init_read_progress_counts/_update_init_read_progressinfoxair_phnix_control.pyso the existinginit_progress_barandstatus_labelreflect Display-Modbus deterministic steps and busy/indeterminate waiting (usessetRange(0,0)for busy phases and switches back to deterministic ranges when available).display_known_init_progress_doneanddisplay_known_init_progress_totaland incrementing logic so the progress bar advances only on real events (trigger sent, response received, block processed, retries), not timers._notify_timer_sg_write_statusand calling it from the Display timer/SG write flow (_display_timer_batch_send_current_step,_display_timer_batch_check_step_ack) so editorstatus_labels show step sent / ACK / 0BC3-confirm / optional-ACK warning / failure, without changing write semantics.Testing
python -m compileall .and compilation succeeded.PYTHONPATH=. pytestand automated test suite passed:16 passed, 2 skipped.Codex Task