fix: preserve paired series fill boundaries#31
Open
zao111222333 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, series-to-series fills were first reduced to strictly increasing
xcoordinates before interpolation. This dropped duplicatexvalues and could flatten or remove vertical step edges, producing incorrect filled regions for step-like boundaries. It also could not represent boundaries that are naturally paired byyinstead ofx.This PR updates fill generation so that:
xcoordinates are filled segment-by-segmentycoordinates are also filled segment-by-segmentxinterpolation fallbackDemo
Before:
Now:
Demo code: