fix(byok): reconcile runtime key pools after config changes - #29
Merged
dondai1234 merged 1 commit intoJul 24, 2026
Merged
Conversation
dondai1234
force-pushed
the
fix/byok-key-pool-refresh
branch
from
July 23, 2026 23:59
71893b3 to
e204b30
Compare
dondai1234
force-pushed
the
fix/byok-key-pool-refresh
branch
from
July 24, 2026 00:01
e204b30 to
df33ff6
Compare
dondai1234
added a commit
that referenced
this pull request
Jul 24, 2026
Three community bug fixes by @robbyczgw-cla: - Focus context isolation (#27): scope smart_fetch request context via decorator - Region cache identity (#28): explicit region in search cache key - BYOK pool reconciliation (#29): removed/reordered keys without restart 709 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconcile existing in-memory BYOK key pools with the current configuration during refresh. Removed and reordered keys now take effect without a server restart while cooldown/health state for retained keys is preserved.
Type of change
Checklist
pytest tests/passes locally:704 passed, 5 deselected.server.py.CHANGELOG.mdupdated underUnreleased.Notes for review
The pool object is retained so active engine instances continue to reference it. Its key membership/order and state map are reconciled in place, and the rotation cursor is moved to the next surviving key where possible.
Tests cover partial removal and reordering, deletion around the rotation cursor, retained cooldown state, and complete provider removal.
Fixes #26