fix: declare ios component correctly - #27
Conversation
|
Hello @dominicstop - do you think you're able to merge this? |
|
hello, @fobos531 |
|
Also @dominicstop I'm not sure what your policy is on the supported react native versions, but once you start supporting only RN 0.80+ for this library, I think we can migrate to the new format for this. react/react-native#49941 So would become |
|
@fobos531 thank you vey much for the detailed info! i've been out of the loop w/ RN lately so i'll have to read up on this... in the meantime, if you have any other PR's you want merge, please let me know! |
|
@dominicstop Thank you, much appreciated! This one dominicstop/react-native-ios-context-menu#132 probably also needs a merge for this to work fully. #28 and #29 in this repo also look like they would be useful to merge, but maybe @itsramiel should provide more context on it first, or whether they feel confident that it can be merged. |
|
okie, i will check |
|
hello @itsramiel ✨ thanks very much for your fixes; i've released a new verion with your changes: i'm still trying to get the updated example to run (that's why it's a prepatch |
|
Awesome! let me know if you have a problem running the example app! |
Btw I just want to say you are such a valuable addition to the RN ecosystem. RN has been growing lately and there are many talented people working on it. You are def one of them! |
|
hello, i'm releasing a new patch w/ your changes (patch 5.1.8) + additional fixes for paper (just had to do some testing first) had to make a minor fix, but everything seems to work-ish in both fabric + paper (It would be nice to also do this for the other libs too but i just don't have the time atm unfotunatley)
**Screenshots**:
|

Currently the example app on version 0.77 crashes because of this
Configure iOS components correctly according to codegen. Check docs.