refactor: consolidate duplicated code across the workspace - #597
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Share helpers, test fixtures, and CI steps instead of repeating them - Fix drifted connection key format, RTT thresholds, and process placeholder - Drop redundant aarch64 and Android static release jobs
domcyrus
force-pushed
the
refactor/dedup
branch
from
September 3, 2026 06:18
5bc396a to
c16b78f
Compare
- remove dead page/first/last selection wrappers in UIState - remove unused From<&Connection> for ConnectionKey - fill CHANGELOG gaps for the dedup refactor
- drop label-only, phase/step, and "used to" narration comments - fix stale docs (overview separator, clipboard, merge, QUIC strategy order) - replace all em dashes in source comments and strings
- rename LinkLayerType::RawIP/LinuxSLL/LinuxSLL2 to RawIp/LinuxSll/LinuxSll2 - rename UIState to UiState - uppercase RTT, PCAPNG, STUN, NTP in labels, messages, and prose
- release.yml: tag and overwrite_assets dispatch inputs; run from main against an existing tag - shared upload action skips assets already on the release (downstream checksum pins) - test-platform-builds: create-archives dispatch input to exercise the archive step - MatchQuality::as_str takes self by value again; pin Connection::key() format with a test - CHANGELOG and RELEASE.md updates
- CodeQL flags checking out a dispatch input in the reusable build workflow - keep skip-existing uploads and overwrite_assets; document the tag dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates duplicated helpers, test fixtures, and CI steps across all crates (104 files, about 2,000 net lines removed).
Verified with fmt, clippy, and the full test suite on macOS and Linux. Windows and FreeBSD changes rely on CI.