Return no such table for dolt_workspace_<missing> - #3073
Merged
Merged
Conversation
PRAGMA table_xinfo on a missing table has zero columns, and sqlite3_malloc(0) is NULL, so doltliteGetColumnNames returned NOMEM. dolt_workspace_nope then surfaced as out of memory (7) while dolt_diff_nope already said no such table. Treat a zero-column lookup as empty, not OOM, and map that connect failure to SQLITE_ERROR with no such table: <module name>. Fail-before: SELECT * FROM dolt_workspace_nope printed out of memory (7). Fixes #3036. Co-Authored-By: Grok 4.6 <noreply@x.ai>
|
SummaryCoverage focuses on database table discovery and error handling, including normal access to a valid workspace, clear behavior for missing tables, preservation of requested names, recovery after an error, and isolation of simultaneous requests. These are primarily edge-case, failure-recovery, and concurrency behaviors, with no application bugs observed. Safe to merge — the run found no regressions, new failures, or previously flagged failures attributable to this PR, and all exercised behaviors passed. No merge blocker was identified. Tests run by Ito
Tip Reply with @itoqa to send us feedback on this test run. |
Collaborator
Author
|
@itoqa thanks for the 8/8 on The missing-workspace case is the one this PR changes: |
Contributor
|
Gate: success · CI run Performance hotspotsPR-base gates: 1.25× per workload and 1.15× per section/suite, with a 10 ms minimum regression and confirmation across three attempts. Stock ratios expose standing gaps and are reported separately. Large Table Scans
Add Column With Default
Large Index Edits
|
Contributor
DoltLite source coverage
Merged 135 pooled raw profiles from the distributed Linux correctness jobs. Per-file coverage (103 files)
|
Contributor
DoltLite performance vs PR base
blobpk details
compositepk details
int details
textpk details
vc details
All relative performance gates passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`SELECT * FROM dolt_workspace_nope` returned `out of memory (7)` while `dolt_diff_nope` / `dolt_history_` / `dolt_at_` already said `no such table`. Callers treat SQLITE_NOMEM as fatal.
`PRAGMA table_xinfo` on a missing table has zero columns. `sqlite3_malloc(0)` is NULL, so column load returned NOMEM. Treat that as an empty table and map the connect failure to `no such table: dolt_workspace_nope`.
Fail-before: `out of memory (7)`. After: workspace suite 55/55, including the missing-table message.
Fixes #3036.
Co-Authored-By: Grok 4.6 noreply@x.ai