feat!: remove unmaintained plugn gateway path - #289
Merged
josegonzalez merged 1 commit intoApr 30, 2026
Conversation
Drops the `gateway`, `trigger-gateway`, and `reload-gateway` subcommands, the `example/plugins/available/remote/` demo plugin, and the `github.com/dokku/duplex` and `github.com/progrium/plugin-demo` dependencies pinned to 2016 commits. Nothing in Dokku invokes the gateway path, and a leak/bug audit (see issue #288) turned up panics on transient socket errors, leaked channels, missing `SIGTERM` handling, untracked goroutines, deadline-less `io.Copy`, and a handful of races and busy-loops in the upstream packages that cannot be fixed without forking them. Plugins that relied on coproc-style background processes via the gateway socket will need to migrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the
gateway,trigger-gateway, andreload-gatewaysubcommands, theexample/plugins/available/remote/demo plugin, and thegithub.com/dokku/duplexandgithub.com/progrium/plugin-demodependencies pinned to 2016 commits. Nothing in Dokku invokes the gateway path, and a leak/bug audit (see #288) turned up panics on transient socket errors, leaked channels, missingSIGTERMhandling, untracked goroutines, deadline-lessio.Copy, and a handful of races and busy-loops in the upstream packages that cannot be fixed without forking them. Plugins that relied on coproc-style background processes via the gateway socket will need to migrate.Closes #288.