Repository navigation
fix(tools): correct support and account contracts and descriptions - #330
Merged
Merged
Conversation
adamgajzlerowicz
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket lists ignored
pageSize, and creation required a timestamp the API ignores. This PR sends integer sizes 1–100 asmaxResults(default 40), makescreatedoptional and strips it from requests, and accepts the two missing support platform IDs.Descriptions now explain support catalogs and product displayName routing, page-local ticket/asset matching, asset filters and lookup limits, users/invite restrictions, and spend commitments. The search prompt retains
pageSize=100on every subsequent cursor call and its five-page bound.Base refresh validation
Integrated
mainate5845c4in59cb5ae, preserving the PR changes with no unresolved file conflicts. The combined branch passed 1,224 root tests, 288 integration tests, check:dev, check:ci, build, and whitespace checks.The live comparison below records the earlier
dbf4862feature code. Current main also adds sanitized API-error propagation and 401 MCP authentication metadata; the generic-error limitation in that historical comparison no longer describes the refreshed branch. This base update used deterministic validation and made no remote writes.Real development validation
Compared baseline
15b6b1cwith feature codedbf4862in separately installed and built disposable directories. Actual built stdio MCP servers used https://api-dev.doit.com, the repository credential helper's DEV personas, and equivalent inputs. 142 tools/call requests yielded 131 real API GET requests; no remote writes. API responses and MCP results were checked separately.Cleanup completed: zero resources created, remaining IDs none. MCP processes, encrypted credential caches and isolated build directories were cleaned up; absence independently verified.
Coverage gaps: successful writes/product routing, invite default/domain/duplicate behavior, pending invitations, organization sharing, hosted OAuth and switched-customer authorization remain unverified or deterministic-only. Positive Google Cloud/Azure commitments and asset lookup beyond 249 entries were unavailable. The 100-ticket dev page had no missing requesters, so the known upstream related-user truncation defect was not reproduced; API batching remains a separate dependency.
Both isolated builds passed. Feature code passed 1,148 root tests, 266 integration tests and all 106 existing schema-parity tests. The evidence update passed check:dev, check:ci and diff checks. Fixtures are not counted as live validation.
CI on current head
59cb5ae: all required checks and all five reported checks passed. PR is mergeable; watcher removed after green.