Repository navigation
fix: align insights, alerts, budgets, and incidents with API contracts - #329
Merged
Merged
Conversation
adamgajzlerowicz
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several tools ignored filters or pagination, dropped useful response fields, or required unrelated fields on partial updates. This change aligns the insights, alerts, budgets, anomalies, and cloud-incident tools with their API contracts.
Validation
main, 1,219 unit tests and 284 integration tests passed locally on Node 22 with Yarn 1.yarn check:dev,yarn check:ci,yarn build, andgit diff --checkpassed. All required Tests/Build and Integration CI jobs passed for both Node floor and Node next on headcf01c6c.15b6b1cand feature revisions ran actual stdio MCPtools/callrequests againsthttps://api-dev.doit.comwith equivalent inputs. The live comparison reproduced recommendation page-size/provider/category/easy-win defects, resource pagination, dropped anomaly fields, budget name filtering, AWS incident filtering, and rejection of name-only alert updates.budgets; the branch now returnsbudgets: [], with a regression test and successful live retest.finally; independent GET requests returned 404 for every created resource. No resources remain.Demo-token filtering and sparse category-page edge cases remain deterministic-test coverage. Additional live alert enum variants, budget writes, hosted OAuth, and switched-customer behavior were not exercised. Status-only updates preserved metadata in both builds; live POST omission cleared the optional description, supporting the revised tool guidance.
The dev comparison preceded the final base-branch integration; the integrated head passed the local and CI suites above. Earlier validation inputs and outcomes are retained in
docs/validation/insights-alerts.json.