Skip to content

pki-core: Add missing EC/ML-DSA profiles to EnableEST upgrade scriptlet #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmishraredhat wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

pki-core: Add missing EC/ML-DSA profiles to EnableEST upgrade scriptlet #5408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion base/server/upgrade/11.9.0/01-EnableEST.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ def update_internal_profiles(self, subsystem):
profiles_to_update = [
'caECInternalAuthSubsystemCert',
'caInternalAuthServerCert',
'caInternalAuthSubsystemCert'
'caInternalAuthSubsystemCert',
'caECInternalAuthServerCert', # Add EC Server profile (Fixes 403 Forbidden on EC EST)
'caMLDSAInternalAuthServerCert', # Add ML-DSA Server profile
'caMLDSAInternalAuthSubsystemCert' # Add ML-DSA Subsystem profile
Comment on lines +93 to +96

@coderabbitai coderabbitai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Do not exit when an earlier profile is already updated.

If caECInternalAuthSubsystemCert or another earlier profile already contains the EST ACL, the return at Lines 107-109 exits update_internal_profiles() before the newly added EC Server and ML-DSA profiles are processed. Partially upgraded installations will therefore still miss these ACLs and can continue returning 403 errors.

Replace that early return with continue so every profile is checked independently.

Proposed fix 
             if 'group="Enterprise EST Administrators"' in config['authz.acl']:
                 logger.info('Internal profile ACLs already updated.')
-                return
+                continue
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'caInternalAuthSubsystemCert',
'caECInternalAuthServerCert', # Add EC Server profile (Fixes 403 Forbidden on EC EST)
'caMLDSAInternalAuthServerCert', # Add ML-DSA Server profile
'caMLDSAInternalAuthSubsystemCert' # Add ML-DSA Subsystem profile
if 'group="Enterprise EST Administrators"' in config['authz.acl']:
logger.info('Internal profile ACLs already updated.')
continue
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@base/server/upgrade/11.9.0/01-EnableEST.py` around lines 93 - 96, In
update_internal_profiles(), replace the early return at the existing EST ACL
check with continue so an already-updated profile does not stop processing.
Ensure every profile, including caECInternalAuthServerCert and the ML-DSA
profiles, is checked independently.

]

for profile in profiles_to_update:
Expand Down
Loading