fix(bip32): EncodePrivateWIF for classic WIF (#2) - #6
Open
xre217 wants to merge 1 commit into
Open
Conversation
EncodeWIF historically returns BIP32 extended keys (dgpv/dgub), not classic Wallet Import Format. Document that and add EncodePrivateWIF() which returns dumpprivkey-style compressed WIF for private keys. Tips DOGE: DTRJECKXfxgnSzGbt7TYRikLPDocqvdmo5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2 — `Bip32Key.EncodeWIF` returns extended keys
`EncodeWIF` has always returned BIP32 extended serialization (`dgpv`/`dgub`), not classic Wallet Import Format. Renaming would break every caller/test that round-trips xprv/xpub via `EncodeWIF`.
Fix (compat-preserving)
If maintainers prefer a breaking rename (`EncodeWIF` → classic, `EncodeExtended` for BIP32), happy to follow up.
DOGE
Tips/contract: `DTRJECKXfxgnSzGbt7TYRikLPDocqvdmo5` · trefongwork@gmail.com