ci: fix the cppcheck gate, and run cppcheck and clang-tidy on PRs at all

.github/workflows/clang-tidy.yml

@@ -12,11 +12,16 @@ name: clang-tidy
 on:
   push:
     branches:
-      - '*-dev-*'
+      - '*-dev*'
       - 'main'
   pull_request:
+    # Deliberately wider than the push filter above: a pull request must be
+    # analysed whichever branch it targets. '*-dev-*' never matched
+    # `0.1.5-dev` itself -- there is nothing after "-dev" -- so this job has
+    # never run on a pull request upstream, only on pushes to fork branches
+    # that happen to carry a suffix. Matches ci.yml's filter.
     branches:
-      - '*-dev-*'
+      - '*'
     paths-ignore:
       - '**/*.md'
       - '**/*.txt'

.github/workflows/cppcheck.yml

@@ -14,11 +14,16 @@ name: cppcheck
 on:
   push:
     branches:
-      - '*-dev-*'
+      - '*-dev*'
       - 'main'
   pull_request:
+    # Deliberately wider than the push filter above: a pull request must be
+    # analysed whichever branch it targets. '*-dev-*' never matched
+    # `0.1.5-dev` itself -- there is nothing after "-dev" -- so this job has
+    # never run on a pull request upstream, only on pushes to fork branches
+    # that happen to carry a suffix. Matches ci.yml's filter.
     branches:
-      - '*-dev-*'
+      - '*'
     paths-ignore:
       - '**/*.md'
       - '**/*.txt'
@@ -79,9 +84,16 @@ jobs:
           path: cppcheck-report.xml
 
       - name: gate on error severity
+        # Only `error` severity is fatal, per the phase-0 policy at the top of
+        # this file. The step previously passed --enable=warning here, which
+        # made every warning fatal too and left the job red on 0.1.5-dev itself.
+        # The full warning/style/performance/portability set is still produced
+        # by the reporting step above and uploaded as an artifact -- nothing
+        # stops being visible, it just stops blocking. Widen this to
+        # --enable=warning once the backlog in the suppressions file is
+        # dispositioned, which is what the header has always intended.
         run: |
           cppcheck \
-            --enable=warning \
             --std=c99 \
             -D__GNUC__ -D__linux__ \
             --inline-suppr \

contrib/analysis/cppcheck-suppressions.txt

@@ -16,3 +16,14 @@ unusedFunction
 // Informational check with a very high false-positive rate on C99 designated
 // initializers; revisit after the Phase 1 backlog triage.
 missingIncludeSystem
+
+// OP-TEE client passes `seed` as a TEEC_MEMREF_TEMP_OUTPUT buffer, which the
+// trusted application fills; cppcheck reads taking its address as a use of an
+// uninitialised value. disposition: false-positive
+uninitvar:src/optee/host/main.c
+
+// cppcheck 2.13 cannot build an AST for the assert() macro as expanded here;
+// this is a parser limitation, not a defect in the code. Re-check on the next
+// cppcheck bump -- 2.13 already cleared three of the four such errors that
+// 2.7 reported. disposition: false-positive
+internalAstError:src/optee/ta/libdogecoin_ta.c