Skip to content

pow, validation: report the condition that actually failed #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xanimo wants to merge 1 commit into
base: 0.1.5-dev
Choose a base branch
from
Open

pow, validation: report the condition that actually failed #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/pow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,22 @@ dogecoin_bool check_pow(uint256_t* hash, unsigned int nbits, const dogecoin_chai
arith_uint256* target = init_arith_uint256();
target = set_compact(target, nbits, &f_negative, &f_overflow);
const uint8_t* target_bytes = (const uint8_t*)target->pn;
if (f_negative || arith_uint256_is_zero(target) || f_overflow || uint256_cmp(target_bytes, params->pow_limit)) {
printf("%d:%s: f_negative: %d target == 0: %d f_overflow: %d\n",
__LINE__, __func__, f_negative, (const uint8_t*)target == 0, f_overflow);
/* Report which rejection condition actually fired. The previous printf passed
"(const uint8_t*)target == 0", a NULL test on the pointer just returned by
init_arith_uint256(), so the "target == 0" column read 0 unconditionally and
never reported arith_uint256_is_zero(). The above-pow-limit term was not
printed at all, so a rejection could show every printed field as 0. */
if (f_negative || arith_uint256_is_zero(target) || f_overflow
|| uint256_cmp(target_bytes, params->pow_limit)) {
/* Evaluate the individual terms only here, on the failure path. Hoisting
them above the condition would report all four but destroy the
short-circuit, so uint256_cmp would run against a target that
set_compact had already flagged as overflowed. Defined behaviour, but
there is no reason to compare a target we have already rejected. */
dogecoin_bool target_is_zero = arith_uint256_is_zero(target);
dogecoin_bool above_pow_limit = uint256_cmp(target_bytes, params->pow_limit);
printf("%d:%s: nbits: 0x%08x f_negative: %d target_is_zero: %d f_overflow: %d above_pow_limit: %d\n",
__LINE__, __func__, nbits, f_negative, target_is_zero, f_overflow, above_pow_limit);
dogecoin_free(target);
return false;
}
Expand Down
10 changes: 5 additions & 5 deletions src/validation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ dogecoin_bool check_auxpow(dogecoin_auxpow_block* block, dogecoin_chainparams* p
where the height is known. */
if (!is_legacy(block->header->version) && params->strict_id && get_chainid(block->header->version) != params->auxpow_id) {
printf("%s:%d:%s : block does not have our chain ID"
" (got %d, expected %d, full nVersion %d) : %s\n",
" (got %d, expected %d, full nVersion %d)\n",
__FILE__, __LINE__, __func__, get_chainid(block->header->version),
params->auxpow_id, block->header->version, strerror(errno));
params->auxpow_id, block->header->version);
return false;
}

Expand All @@ -87,7 +87,7 @@ dogecoin_bool check_auxpow(dogecoin_auxpow_block* block, dogecoin_chainparams* p
cstr_free(s, true);

if (!check_pow(&hash, block->header->bits, params, chainwork)) {
printf("%s:%d:%s : non-AUX proof of work failed : %s\n", __FILE__, __LINE__, __func__, strerror(errno));
printf("%s:%d:%s : non-AUX proof of work failed\n", __FILE__, __LINE__, __func__);
return false;
}

Expand All @@ -101,15 +101,15 @@ dogecoin_bool check_auxpow(dogecoin_auxpow_block* block, dogecoin_chainparams* p
dogecoin_block_header_scrypt_hash(s2, &parent_hash);
cstr_free(s2, true);
if (!check_pow(&parent_hash, block->header->bits, params, chainwork)) {
printf("%s:%d:%s : AUX proof of work failed: %s\n", __FILE__, __LINE__, __func__, strerror(errno));
printf("%s:%d:%s : AUX proof of work failed\n", __FILE__, __LINE__, __func__);
return false;
}

uint256_t block_header_hash;
dogecoin_block_header_hash(block->header, block_header_hash);
uint32_t chainid = get_chainid(block->header->version);
if (!block->header->auxpow->check(block, &block_header_hash, chainid, params)) {
printf("%s:%d:%s : AUX POW is not valid : %s\n", __FILE__, __LINE__, __func__, strerror(errno));
printf("%s:%d:%s : AUX POW is not valid\n", __FILE__, __LINE__, __func__);
return false;
}

Expand Down
Loading