context: move context definitions into dogecoin/context.h - #396
Open
edtubbs wants to merge 1 commit into
Open
Conversation
Adds include/dogecoin/context.h so src/context.c and test/context_tests.c no longer include the public dogecoin/libdogecoin.h API header, removes the duplicate SEED typedef and fixes nested comment markers in libdogecoin.h.
xanimo
approved these changes
Aug 4, 2026
Member
There was a problem hiding this comment.
ACK
tested on x86_64-pc-linux-gnu with 78/78 WITH_NET=ON, 72/72 OFF, no warnings.
SEED removal safe — dogecoin.h:212/234, installed, included by libdogecoin.h:36
Comment fixes cosmetic
context.c swap corrects a latent type mismatch: two dogecoin_chainparams layouts (2136 vs 2236, default_port at offset 84 vs 116). context.c never dereferenced a field, so nothing was misread.
Unfixed, separate issue: libdogecoin.h still exports dogecoin_chainparams_main with the 2136 layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds include/dogecoin/context.h so src/context.c and test/context_tests.c no longer include the public dogecoin/libdogecoin.h API header, removes the duplicate SEED typedef and fixes nested comment markers in libdogecoin.h.