fix(api): upsert applies payout settings + WebAPI tests (#134 #105) - #161
Open
xre217 wants to merge 1 commit into
Open
fix(api): upsert applies payout settings + WebAPI tests (#134 #105)#161xre217 wants to merge 1 commit into
xre217 wants to merge 1 commit into
Conversation
…ndation#134 dogecoinfoundation#105) POST /account/:id with upsert previously returned the existing account and ignored body fields. Apply payout_address / threshold / frequency on update and cover with WebAPI regression tests. Also assert new invoices start with payment flags false (dogecoinfoundation#105 surface). Tips DOGE: DTRJECKXfxgnSzGbt7TYRikLPDocqvdmo5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#134 — Account update / upsert ignored settings
CreateAccount(..., upsert=true)returned the existing account without applyingpayout_address,payout_threshold, orpayout_frequencyfrom the JSON body. Merchants callingPOST /account/:foreignIDagain could not update payout config.Fix
On upsert, if any payout fields changed,
UpdateAccount+ commit and emitACC_UPDATED.#105 — Testing needs work
Adds WebAPI coverage:
TestAccountUpsertAppliesPayoutSettings— create then upsert, assert settings stickTestInvoicePublicPaymentFlagsBaseline— new invoice not marked paid/detectedPairs with open stack #156–#160.
DOGE tips / contract
DTRJECKXfxgnSzGbt7TYRikLPDocqvdmo5· trefongwork@gmail.com