Add tests around cloneAsHeader()#61
Open
rnicoll wants to merge 1 commit into
Open
Conversation
michilumin
reviewed
Jan 11, 2022
michilumin
left a comment
michilumin
left a comment
Member
There was a problem hiding this comment.
First two files look fine, since they're just reorgs, need to look closer at the doge and lite tests themselves. In process.
rnicoll
force-pushed
the
test-clone-as-header
branch
from
February 12, 2022 11:18
0b009a4 to
c344c33
Compare
rnicoll
force-pushed
the
test-clone-as-header
branch
from
February 14, 2022 08:42
c344c33 to
48ff5df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
cloneAsHeader()was using the previous block hash when setting merkle root, and a test to cover this scenario. Also adds a test of connecting the first Litecoin block to its genesis block.As part of requiring extended block loading, this introduces a dedicated
BlockLoaderutility class.