Repository navigation
Handle root-namespace classes in SymfonyFileLocator - #521
Merged
GromNaN merged 2 commits intoSep 11, 2026
Merged
Conversation
greg0ire
previously approved these changes
Sep 10, 2026
greg0ire
requested review from
GromNaN,
SenseException,
beberlei,
derrabus and
stof
September 10, 2026 17:39
GromNaN
previously approved these changes
Sep 11, 2026
stof
previously approved these changes
Sep 11, 2026
GromNaN
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #520.
When a mapping lookup fails for a class in the root namespace,
strrpos()returnsfalse. The assertion then fails when assertions are enabled; when they are disabled, the subsequentsubstr()starts at offset 1 and reports a filename such asateTime.yml.Use the complete class name when there is no namespace separator, while preserving the existing short-name behavior for namespaced classes. The regression test verifies that
DateTimeproduces the expectedMappingExceptionand filename.Validation:
vendor/bin/phpunit— 146 tests, 306 assertionsvendor/bin/phpcs— 72 filesvendor/bin/phpstan analyse --no-progress --memory-limit=512M— no errors