Repository navigation
Merge 4.2.0 up into 5.0.x - #510
Merged
Merged
Conversation
Merge 4.1.x up into 5.0.x
….x_TA2qrOVB Merge release 4.1.0 into 5.0.x
Merge 4.1.x up into 4.2.x
Add `getFieldValue` and `setFieldValue` to `ClassMetadata` interface
Add test on unbound scope of the included file Deprecate updating $metadata variable in the php file directly Exclude _files directory from PHPStan inspection
Support closure returned by `.php` files in the `PHPDriver`
Merge 4.1.x up into 5.0.x
Merge 4.1.x up into 4.2.x
Merge 4.2.x up into 5.0.x
Merge 4.1.x up into 4.2.x
Merge 4.2.x up into 5.0.x
Merge 4.1.x up into 4.2.x
Merge 4.2.x up into 5.0.x
This is consistent with other Doctrine projects. Note that I had to add a "covariant" keyword on the template definition of getReflectionClass() return type. That's because since PHP 8.4, ReflectionClass is considered invariant because of lazy objects. Lazy objects introduce new methods to ReflectionClass where the template appears in parameter position, for instance that is the case for isUninitializedLazyObject(). I do not understand why this wasn't an issue with ReflectionClass::isInstance(), which was introduced way earlier than that though. The solution I picked is to use "call-site variance", effectively saying that this is OK in this instance (but it might not be, I'm not sure). The alternative to adding this keyword would be to drop generic information entirely. See phpstan/phpstan#12459 for more details.
Deprecate `ClassMetadataFactory::setMetadataFor()`
Require PHP 8.4
Not necessary when using native lazy objects with PHP 8.4+
Make `AbstractManagerRegistry::$proxyInterfaceName` nullable
Deprecate `Proxy` interface and related
Merge 4.1.x up into 4.2.x
Conflicts: src/AbstractManagerRegistry.php doctrine#460 doctrine#458
Merge 4.2.x up into 5.0.x
Mark classes as soft final
Merge 4.2.x up into 5.0.x
Make soft-final classes final
It is no longer clear to me why I did not make the AbstractManagerRegistry::$connections and AbstractManagerRegistry::$managers readonly already in 59029af.
The class is final and has no parent, so this is fine.
Modernize the codebase
Merge 4.1.x up into 4.2.x
Used configuration: <?php declare(strict_types=1); use Rector\Config\RectorConfig; return RectorConfig::configure() ->withPaths([ __DIR__ . '/src', ]) ->withPhpSets();
Merge 4.2.x up into 5.0.x
https://github.com/doctrine/orm/blob/3.6.x/src/EntityRepository.php already has this narrowed return type
findAll and findBy should return list
Use the ColocatedMappingDriver that provides this feature
….Mapping.PHPTestEntityAssert.php that asserts $metadata variable existence
…c API The trait was used without restrictions, leaking addPaths, getPaths, addExcludePaths, getExcludePaths, getFileExtension, and setFileExtension as public methods. Alias them all to private to keep the public API limited to the MappingDriver interface. Add a test that asserts the exact list of public methods on StaticPHPDriver to prevent regressions.
Support ClassLocator in StaticPHPDriver
….x_Ir7uGPdR Merge release 4.1.2 into 4.2.x
Member
Author
|
Woops, I should undo this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.