Repository navigation
Conversation
getParametersForItem() read every ORDER BY value from the result item, even when the ORDER BY item was on a joined alias, so building a cursor crashed with "Call to a member function getValue() on null". CursorWalker now records the single-valued associations that lead from the root alias to the item's alias, and CursorPaginator follows them to read the value. Proxies are initialized, a null association yields a null cursor value, and an alias reached through a collection is rejected with a LogicException. Results that are not entities keep reading the property named after the field. Based on doctrine#12671 by Guillaume Sainthillier. Co-authored-by: Guillaume Sainthillier <guillaume.sainthillier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building a cursor for an
ORDER BYon a joined alias read the value from the root item, soORDER BY a.numbercrashed withCall to a member function getValue() on null.CursorWalkernow records the single-valued associations from the root alias to the item's alias, andCursorPaginatorfollows them to read the value. Proxies are initialized, a null association yields a null cursor value, and an alias reached through a collection throws aLogicException. Scalar and mixed results are not covered.Tests cover a selected joined entity, an unselected one behind a proxy, a DTO result, and a collection join.
Based on #12671 by @guillaume-sainthillier.
Fixes #12670.