Repository navigation
Conversation
The paginator disables the PHP value conversion while generating its identifier subquery, so ORDER BY uses the stored column instead of the converted value. This keeps custom types with a non-reversible conversion from selecting the wrong page.
The tree walker does not add ORDER BY expressions to the SELECT list, which MySQL rejects with DISTINCT. That is a separate pre-existing limitation.
GromNaN
marked this pull request as ready for review
October 29, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paginator's identifier subquery applied the mapping type conversion to the column used by
ORDER BY, so custom types with a non-reversible conversion selected the wrong page. It now orders on the stored column, while the hydration query still applies the conversion.SELECT DISTINCT id_0 FROM ( SELECT DISTINCT id_0, LENGTH(boundary_1) FROM ( - SELECT g0_.id AS id_0, TRIM(g0_.boundary) AS boundary_1, g0_.label AS label_2 + SELECT g0_.id AS id_0, g0_.boundary AS boundary_1, g0_.label AS label_2 FROM GH5839Zone g0_ ) dctrn_result_inner ORDER BY LENGTH(boundary_1) ASC ) dctrn_result LIMIT 2Fixes #5839.