Use open-api plugin settings instead of global ones - #211
Open
w666 wants to merge 1 commit into
Open
Conversation
- This is to respect setting `download` and display download link for api spec - Use the same URL as a provided to plugin when generate download URL, so it does not try to download with a page prefix Close docmd-io#210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadand display download link for api specDetailed description:
In my example I have the following structure:
I provide relative path in MD page, for example:
this page has URL
example.com/doc/api/my-api/, so download link isexample.com/doc/api/my-api/my-spec.yamlwhich is not correct, it does not match the path. Instead it should beexample.com/doc/api-specs/my-spec.yamlFixes #210
Type of change
Checklist: