Fix browser back trough latest version - #932
Conversation
…st" version, when the version is for example called v1.0.1, by splitting version and displayVersion in the code
…Context Providers to keep their state, to prevent them from showing outdated information a reloadIntervalSeconds with a default of 30s was introduced, to prevent flickering on project updates a diff logic was introduced before the state update and the iframe was adapted to only refresh if the current version changes. For example, adding versions to other Projects should not refresh the iframe nor should the iframe update when older versions get added to a Project.
|
Hoi 👋 thanks for your contribution can you please break this down into smaller merge requests? In the current state this is very hard to review.
I don't think this is a feature we want to support so you can drop it completely, which should resolve the need to document it :) |
|
Thanks for the fast feedback. I will remove everything other than the bugfix from this Pull Request and create a separate one for React state handling / navigation improvements. This should also clarify which changes are required for which functionality. |
|
@tbuerli-komax Did you see -> #934 which i believe is trying to fix the same issue |
|
The merge request by ioasjfopas #934 chooses to update the parameter used by the URL directly. This has the tradeoff that navigation through the documentation changes the version in the URL away from "/latest" to the exact version. @fliiiix please check both merge requests and give me feedback on which solution is preferred by you. |
|
Thanks for this fix cherry-picked th the other mr and merged. I will close these here but as discussed in the other mr i am interested in better testing for the navigation and a simpler implementation if thats something you want to work on im more than happy to see other mrs from you! ✨ |
Bug: Browser back navigation doesn't work when navigating back through the "latest" version.
How to reproduce:
Changes done:
I hope this matches the coding style of the repository. It was a bit unclear to me where the documentation for the
reloadIntervalSecondsshould go. Is this better in the main README.md as an example parameter or in the web/README.md as an additional section?