Repository navigation
fix(discovery): isolate nested repositories and protect bootstrap destinations - #113
Merged
Merged
Conversation
Scope: offline analysis only; no execution, dependency, CI or release changes. Tests and docs travel with this behavior unit. Combined working-tree full Go suite, vet and 80-call public differential passed; independent committed-source verification follows. Risk: item 3 (shared snapshot/report consumers).
Treat an excluded repository occupying the draft destination as unsafe, as well as its ancestors. Pin the owned public CLI regression and correct the documented diagnostic. RED1/GREEN0, full Go suite/vet0 and 16-call differential passed. Risk: item 3 (shared bootstrap contract); independent blocker-only recheck follows. (cherry picked from commit 716ee1c22658a7e1cec79b5e92e1dfa325973cf4)
9 of 14 tasks
12 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #3
Follow-up to the already completed discovery contract. The issue stays closed; its
status:approvedlabel was explicitly authorized for this follow-up. This does not close or change the deferred controlled-verification work.PR type
Summary
.gitentries using confined metadata only; preserve explicitly selected roots and ordinary nested packages.Changes
internal/discovery/snapshot.goand testsinternal/bootstrap/bootstrap.gocmd/ci-trust/discovery_scope_test.godocs/discovery.md,docs/bootstrap.mdTest plan
go test -count=1 ./...andgo vet ./...passed in an isolated canonical archive.Remote Linux/Windows/macOS execution is required through this PR's checks; local Windows checks are not portable-execution proof. Marker-inspection error handling was source-inspected, not fault-injected; nonverbose historical symlink skip status was not established. Native assessment was unassessable, not approval; independent source verification ran.
Contributor checklist
type:*PR label.Co-Authored-Bytrailers.Chain Context
mainatb16b7cbff841239d493e308802849f02395bef56feat/audit-review-summaryIncludes reader/bootstrap behavior, tests and docs. Excludes summary presentation, broad copied-directory inference, runtime execution and releases. Roll back this unit independently. Review only; no automatic merge, rebase, squash or branch deletion. The follow-up can be retargeted after a later authorized merge commit, without rewriting original history.
Risk: item 3 (shared snapshot and bootstrap contracts).