fix(tui): route tracing to log file in TUI modes - #68
Closed
dnacenta wants to merge 1 commit into
Closed
Conversation
Stdout tracing on the TUI alternate screen corrupts ratatui's render. Defer tracing init for Chat and non-headless Up to a file-backed writer at <root>/logs/pulse-null.log. Other commands continue to use stdout. - New init_stdout_tracing / init_file_tracing helpers in cli::mod. - main detects TUI commands and calls init_stdout_tracing only when not. - chat::run and up::run_single_entity / run_multi_entity init the file writer from the entity root or entity-home dir.
Owner
Author
|
Closing: 3 months stale (41 commits behind), CI red, and main has since touched the same files. Will redo file-based TUI tracing fresh if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chatand interactiveup.init_stdout_tracing(default CLI) andinit_file_tracing(TUI). TUI logs land in<root>/logs/pulse-null.log.maindetects TUI commands (Chat,Up { headless: false }) and skips stdout init; the TUI handlers initialize the file writer themselves once they know their entity root.Test plan
cargo fmt --checkcargo clippy -- -D warnings -A dead_code(matches CI)cargo build(default features)cargo test+cargo build --releasepulse-null chat— render is clean, logs accumulate in<root>/logs/pulse-null.logpulse-null up(interactive) — samepulse-null up --headless— logs still go to stdout (server mode unchanged)