Fix custom time input#2
Merged
Merged
Conversation
Instead of a single text field where users struggled to input colons with the number keyboard, we now use two separate numeric fields for Minutes and Seconds. Fixes #1 Co-authored-by: dmx3377 <228389106+dmx3377@users.noreply.github.com>
dmx3377
added
the
working
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The GitHub Actions workflow failed because the Gradle task referred to `:wearos:assembleRelease`. The actual name of the module is `:focustimer-wearos`. Updated the CI workflow to use the correct path so the APKs can build correctly. Co-authored-by: dmx3377 <228389106+dmx3377@users.noreply.github.com>
The `autobuild` setting caused the CodeQL action to generate a SARIF file that could not be processed when the default setup is enabled (as seen in the error: "CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled"). Changing build-mode to `none` allows the overlay database to be built correctly and processed. Co-authored-by: dmx3377 <228389106+dmx3377@users.noreply.github.com>
…paths There were more references to the incorrect module path (`wearos/`) in the jarsigner, zipalign, and upload artifact steps. Those have now been updated to `focustimer-wearos/`. Co-authored-by: dmx3377 <228389106+dmx3377@users.noreply.github.com>
The `autobuild` build-mode for CodeQL was failing because it could not correctly parse the Android/Kotlin/Java repository. And the `none` mode, while able to generate a database, did not correctly compile the code and triggered a failure during the upload phase regarding advanced setups missing actual code analyses. Setting the build-mode to `manual` and manually running `chmod +x gradlew` and `./gradlew build` allows the CodeQL action to hook into the compilation correctly and succeed. Co-authored-by: dmx3377 <228389106+dmx3377@users.noreply.github.com>
Owner
Author
|
Won't merge until I've tested it later... |
The 'none' build-mode does not actually perform the CodeQL analysis and is not sufficient for Java/Kotlin projects. 'autobuild' fails for Gradle. Using 'manual' and explicitly running './gradlew build' performs the compilation correctly for the advanced CodeQL setup. Co-authored-by: dmx3377 <228389106+dmx3377@users.noreply.github.com>
Owner
Author
|
Works as expected. Merging... |
dmx3377
removed
the
working
Repository owner
locked as resolved and limited conversation to collaborators
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the bug where users could not input seconds due to the number keyboard not allowing a colon character. Replaced the single input field with two separate fields (Min and Sec) inside the custom timer dialog.
PR created automatically by Jules for task 16573684281896944504 started by @dmx3377