Skip to content

fix(ci): fix node/bun build step - #781

Open
dmtrKovalenko wants to merge 1 commit into
mainfrom
fix/npm-pulish
Open

fix(ci): fix node/bun build step#781
dmtrKovalenko wants to merge 1 commit into
mainfrom
fix/npm-pulish

Conversation

@dmtrKovalenko

@dmtrKovalenko dmtrKovalenko commented Aug 15, 2026

Copy link
Copy Markdown
Owner

unf*ck the npm publishing CI script

Summary by CodeRabbit

  • Chores
    • Improved release workflows for more reliable package building, versioning, and publishing.
    • Releases now run from the main branch and version tags.
    • Consolidated formatting, linting, validation, and dependency management in the packages workspace.
    • Updated development and testing commands to use workspace dependencies consistently.
    • Improved package version synchronization and platform-specific package handling during releases.
    • Updated Node.js package builds to produce both ESM and CommonJS formats.
    • Removed obsolete package-specific installation and build steps.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f7ec119c-79ce-4b1f-848e-81ff08605955

📥 Commits

Reviewing files that changed from the base of the PR and between 774d6bc and 4d662ef.

⛔ Files ignored due to path filters (2)
  • packages/bun.lock is excluded by !**/*.lock
  • packages/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • packages/fff-node/package.json

Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The repository moves package tooling into packages. Version updates use a dedicated script. Release and external-test workflows use updated workspace paths, build commands, and publishing order.

Changes

Workspace publishing migration

Layer / File(s) Summary
Workspace manifest and tooling
package.json, packages/package.json, Makefile
The root manifest keeps the pi extension entry. The packages manifest defines workspace packages and Biome commands. Makefile targets use the updated build, versioning, formatting, and linting paths.
Package versioning and native dependencies
scripts/set-npm-version.mjs, packages/fff-bun/package.json, packages/fff-node/package.json
The versioning script updates package versions, workspace references, optional dependencies, and platform package dependencies. The Bun and Node manifests remove platform dependency declarations. Node uses tsup for ESM and CJS bundles.
CI and release workflow paths
.github/workflows/release.yaml, .github/workflows/external-tests.yml
Release jobs use updated branch triggers and build packages before versioning. External tests install dependencies from packages and stage the musl binary under packages/node_modules.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 4d662

The current changes do not present an actionable merge-blocking risk; the PR is merge-ready after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant ReleaseWorkflow
  participant PackagesWorkspace
  participant VersionScript
  participant npmRegistry
  ReleaseWorkflow->>PackagesWorkspace: Install dependencies and build packages
  ReleaseWorkflow->>VersionScript: Update versions and package dependencies
  VersionScript-->>ReleaseWorkflow: Write updated manifests
  ReleaseWorkflow->>npmRegistry: Publish packages
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the CI build-step changes, but it does not cover the broader npm publishing and workspace restructuring.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/npm-pulish

Comment @coderabbitai help to get the list of available commands.

@dmtrKovalenko dmtrKovalenko changed the title fix(ci): regenaraate bun.lock fix(ci): regenarate bun.lock Aug 15, 2026
@dmtrKovalenko
dmtrKovalenko force-pushed the fix/npm-pulish branch 4 times, most recently from 9f841e0 to 774d6bc Compare August 16, 2026 01:58
unf*ck the npm publishing CI script
@dmtrKovalenko dmtrKovalenko changed the title fix(ci): regenarate bun.lock fix(ci): fix node/bun build step Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant