feat(grep): Jump to next file match segment#595
Open
Hex4C wants to merge 1 commit into
Open
Conversation
Author
|
Force pushed to remove picker_ui.lua (original before refactor), accidentally added it. |
Author
|
Messed up the test setup, fixed now and passes the 4 unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully closes #512
Heavily inspired by #532 (squashed based on that PR)
Since a majority of the logic already was implemented and only needed to be slightly adapted to the new structure for the picker_ui I wrote a majority of the code with LLM assisted tools.
I did the same thing for the unit test, but I am less certain of them... They seemed slightly dated, they can almost certainly be improved.
I have tested the UI for edge cases such as no files, 1 file and multiple files etc and it has worked flawlessly so far.
Feedback is greatly appreciated or edit the files directly if you wish. Hope this helps!