Fix win arm64 release. - #12394
Open
trivialfis wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Windows ARM64 Python wheel release for the xgboost PyPI package (previously only the xgboost-cpu variant was released for aarch64 on Windows) and adds CI coverage to validate the produced Win ARM64 wheel.
Changes:
- Include
win_arm64in the release artifact downloader so Win ARM64 wheels are fetched for release packaging. - Add a Win ARM64 wheel test job that downloads the built wheel artifact, installs it, and runs a basic Python test.
- Adjust Conda test environments and update installation documentation to reflect platform support changes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ops/script/release_artifacts.py | Adds win_arm64 to the list of platforms when downloading Python wheel artifacts. |
| ops/conda_env/win64_test.yml | Tweaks Windows test environment dependencies (CUDA + pip-installed py-ubjson). |
| ops/conda_env/win64_cpu_test.yml | Introduces a CPU-focused Windows test Conda environment for wheel validation. |
| ops/conda_env/macos_cpu_test.yml | Adjusts macOS CPU test environment dependencies (moves py-ubjson to pip section). |
| doc/install.rst | Updates platform support documentation and wheel capability table. |
| .github/workflows/windows.yml | Renames the Windows CUDA test job identifier. |
| .github/workflows/python_wheels_winarm64.yml | Uploads the Win ARM64 xgboost wheel as an artifact and adds a job to test installing/running it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xgboost-cpu, but not thexgboostpackage. This PR fixes that.xgboostWin ARM64 package.At the moment, the
xgboostandxgboost-cpupackages should be identical. I'm keeping both packages to avoid confusing existing users and to preserve the opportunity to support ARM-based GPU devices.