-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate to CTK 13 as the default for Linux. #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6d7c957
Migrate to CTK 13 as the default for Linux.
trivialfis 84da0e2
cmake version.
trivialfis cfde442
all images.
trivialfis f7dc1a5
clang, rmm.
trivialfis e799240
Drop clang tidy container.
trivialfis e64908b
Drop federated learning.
trivialfis cd17a29
CTK 12 images.
trivialfis 56859a4
Install polars.
trivialfis 789a5e8
Disable modin.
trivialfis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,8 @@ ARG CUDA_VERSION | |
| ARG NCCL_VERSION | ||
| ARG RAPIDS_VERSION | ||
| ARG ARCH=x86_64 | ||
| ARG MINIFORGE_VERSION=24.9.2-0 | ||
| ARG CMAKE_VERSION=3.31.2 | ||
| ARG MINIFORGE_VERSION=26.3.2-3 | ||
| ARG CMAKE_VERSION=4.1.0 | ||
|
|
||
| SHELL ["/bin/bash", "-c"] | ||
|
|
||
|
|
@@ -39,29 +39,19 @@ RUN \ | |
| dnf -y update && \ | ||
| dnf install -y libnccl-${NCCL_VERSION}+cuda${CUDA_SHORT} libnccl-devel-${NCCL_VERSION}+cuda${CUDA_SHORT} | ||
|
|
||
| # Install gRPC | ||
| # Patch Abseil to apply https://github.com/abseil/abseil-cpp/issues/1629 | ||
| RUN git clone -b v1.65.4 https://github.com/grpc/grpc.git \ | ||
| --recurse-submodules --depth 1 && \ | ||
| pushd grpc && \ | ||
| pushd third_party/abseil-cpp && \ | ||
| git fetch origin master && \ | ||
| git cherry-pick -n cfde5f74e276049727f9556f13473a59fe77d9eb && \ | ||
| popd && \ | ||
| cmake -S . -B build -GNinja -DCMAKE_INSTALL_PREFIX=/opt/grpc -DCMAKE_CXX_VISIBILITY_PRESET=hidden && \ | ||
| cmake --build build --target install && \ | ||
| popd && \ | ||
| rm -rf grpc | ||
|
|
||
| # Install RMM | ||
| # Patch out -Werror | ||
| # Force the static logger dependencies to use the container's GCC toolchain instead of | ||
| # reusing ABI-incompatible shared libraries from Miniforge. | ||
| RUN git clone -b v${RAPIDS_VERSION}.00 https://github.com/rapidsai/rmm.git --recurse-submodules --depth 1 && \ | ||
| pushd rmm && \ | ||
| find . -name CMakeLists.txt -print0 | xargs -0 sed -i 's/-Werror//g' && \ | ||
| pushd cpp && \ | ||
| mkdir build && \ | ||
| pushd build && \ | ||
| cmake .. -GNinja -DCMAKE_INSTALL_PREFIX=/opt/rmm -DCUDA_STATIC_RUNTIME=ON -DBUILD_SHARED_LIBS=OFF -DBUILD_TESTS=OFF && \ | ||
| cmake .. -GNinja -DCMAKE_INSTALL_PREFIX=/opt/rmm -DCUDA_STATIC_RUNTIME=ON \ | ||
| -DBUILD_SHARED_LIBS=OFF -DBUILD_TESTS=OFF \ | ||
| -DCPM_DOWNLOAD_fmt=ON -DCPM_DOWNLOAD_spdlog=ON && \ | ||
|
Comment on lines
+52
to
+54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, we should be able to remove this once we rip out the RMM integration from XGBoost |
||
| cmake --build . --target install && \ | ||
| popd && popd && popd && \ | ||
| rm -rf rmm | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.