Skip to content

Add CCID support - #127

Open
kidbomb wants to merge 7 commits into
dmitrystu:masterfrom
kidbomb:master
Open

Add CCID support#127
kidbomb wants to merge 7 commits into
dmitrystu:masterfrom
kidbomb:master

Conversation

@kidbomb

@kidbomb kidbomb commented May 11, 2023

Copy link
Copy Markdown

No description provided.

@kidbomb kidbomb changed the title Add USB_DTYPE_FUNCTIONAL_DESC constant Add CCID support May 11, 2023
@kidbomb

kidbomb commented Jun 3, 2023

Copy link
Copy Markdown
Author

@dmitrystu Any chance of getting this merged?

@dmitrystu

Copy link
Copy Markdown
Owner

Sorry for the very late reply.
I need to check specs. https://www.usb.org/sites/default/files/DWG_Smart-Card_CCID_Rev110.pdf.

Comment thread inc/usb_std.h Outdated
Comment thread inc/usb_ccid.h Outdated
Comment thread inc/usb_ccid.h Outdated
@kidbomb

kidbomb commented Jun 27, 2023

Copy link
Copy Markdown
Author

Thanks for the review @dmitrystu - those are fixed.

Comment thread inc/usb_ccid.h Outdated
Comment thread inc/usb_ccid.h
Comment thread inc/usb_ccid.h Outdated
Comment thread inc/usb_ccid.h
@dmitrystu

Copy link
Copy Markdown
Owner

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

@kidbomb

kidbomb commented Jun 29, 2023

Copy link
Copy Markdown
Author

Just added all messages now

@kidbomb
kidbomb requested a review from dmitrystu June 29, 2023 22:55
@kidbomb

kidbomb commented Jul 9, 2023

Copy link
Copy Markdown
Author

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

@kidbomb

kidbomb commented Jul 23, 2023

Copy link
Copy Markdown
Author

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

@dmitrystu - Is there anything else you believe is missing? I would like to have this PR merged soon so I can start working on a feature for Flipper Zero

@kidbomb

kidbomb commented Sep 4, 2023

Copy link
Copy Markdown
Author

@dmitrystu - reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants