Add feature : Dijkstra with Node and Edge Objects via Protocol

[topchul]

It's a great implementation of dijkstra.

I compare some implementations.
It's easy to read, so good.

but, It just use Dictionaries.
I want to use with core data or other repositories with objects.

So, I added 2 protocols(Node, Edge).
And clone your algorithm with the protocols.

I added 3 test case testDijkstraWithNodes, testShortestPathWithNodes, testShortestPathWithCirculaNodes.
You can easily check equivalent cases via [graph description].

I want to merge this fearture.

Thanks for your efforts.

test case

• testDijkstraWithNodes - equivalent test case of testDijkstra
• testShortestPathWithNodes - equivalent test case of testShortestPath
• testShortestPathWithCirculaNodes - Dijkstra with a circle nodes.
• DijkstraNode <NSObject, NSCopying> - NSCopying for using a Dictionary Key
• DijkstraEdge - from, to, length
• DijkstraNodeTestImpl.h - Node implementation For Test case.
• DijkstraEdgeTestImpl.h - Edge implementation For Test case.

[dmitrikozlov]

Hi Gregory,

Thank you very much for your input. I am a bit busy at the moment. I will
review your code later and get back to you.

Regards,
Dmitri

On 21 June 2013 12:04, Gregory J.H. Rho notifications@github.com wrote:

It's a great implementation of dijkstra.

I compare some implementations.
It's easy to read, so good.

but, It just use Dictionaries.
I want to use with core data or other repositories with objects.

So, I added 2 protocols(Node, Edge).
And clone your algorithm with the protocols.

I added 3 test case testDijkstraWithNodes, testShortestPathWithNodes,
testShortestPathWithCirculaNodes.
You can easily check equivalent cases via [graph description].

I want to merge this fearture.
Thanks for your efforts.

#test case

• testDijkstraWithNodes - equivalent test case of testDijkstra

• testShortestPathWithNodes - equivalent test case of testShortestPath

  testShortestPathWithCirculaNodes - Dijkstra with a circle nodes.

  DijkstraNode - NSCopying for using a Dictionary Key

  DijkstraEdge

  DijkstraNodeTestImpl.h

  DijkstraEdgeTestImpl.h

---

You can merge this Pull Request by running

git pull https://github.com/topchul/mj-dijkstra master

Or view, comment on, or merge it at:

#1
Commit Summary

• new feature : Dijkstra with ObjectNode and ObjectEdge via
  objective-C protocols
• add missed memory management codes.

File Changes

• M .gitignorehttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-0(4)
• M dijkstra.xcodeproj/project.pbxprojhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-1(12)
• M dijkstra/implementation/MJDijkstra.hhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-2(19)
• M dijkstra/implementation/MJDijkstra.mhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-3(61)
• A dijkstraLogicTests/DijkstraEdgeTestImpl.hhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-4(14)
• A dijkstraLogicTests/DijkstraEdgeTestImpl.mhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-5(43)
• A dijkstraLogicTests/DijkstraNodeTestImpl.hhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-6(19)
• A dijkstraLogicTests/DijkstraNodeTestImpl.mhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-7(95)
• M dijkstraLogicTests/dijkstraLogicTests.mhttps://github.com/Add feature : Dijkstra with Node and Edge Objects via Protocol #1/files#diff-8(159)

Patch Links:

• https://github.com/dmitrikozlov/mj-dijkstra/pull/1.patch
• https://github.com/dmitrikozlov/mj-dijkstra/pull/1.diff