Skip to content

fix(mvcc): deterministic GC Dispose (fixes flaky DisposeStopsBackgroundCollectionTest on main) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitrat merged 1 commit into from
Jun 13, 2026
Merged

fix(mvcc): deterministic GC Dispose (fixes flaky DisposeStopsBackgroundCollectionTest on main) #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Sources/Core/OutWit.Database.Core/Mvcc/MvccGarbageCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,18 @@ public void Dispose()
m_disposed = true;

m_cts.Cancel();
m_timer.Dispose();

// Wait for an already-running timer callback to finish before returning. Timer.Dispose()
// alone does not wait for an in-flight callback, so a collection that started just before
// Dispose could still complete (and bump RunCount) afterwards. The WaitHandle overload
// signals once all callbacks have drained, guaranteeing no background collection runs
// after Dispose returns.
using (var timerCallbacksDrained = new ManualResetEvent(false))
{
if (m_timer.Dispose(timerCallbacksDrained))
timerCallbacksDrained.WaitOne();
}

m_cts.Dispose();
}

Expand Down
Loading