Repository navigation
chore(comments): match work-package labels, handoff sections and finding codes - #59
Merged
Merged
Conversation
…ing codes Extend the review-history comment check with three marker families that it missed: work-package labels (WP3-B, WP-E), handoff section references (handoff §5b) and finding codes (R3-7, R2b, P1-5, F2, B2, D4) that sit next to a review, round, gate or finding word. A finding code on its own never matches, so hex colours, P95, RFC and ADR numbers, HTTP codes and standalone spec section references stay clean. The self-test plants a marker for each new pattern and a legitimate sentence that must pass. Part of dmfdeploy/dmfdeploy#785 Claude-Session: https://claude.ai/code/session_01Rq1iSvhmEwbNUF43rtXVY4 Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
lkirc
approved these changes
Oct 26, 2026
lkirc
left a comment
lkirc
left a comment
There was a problem hiding this comment.
Approved. The expanded markers are scoped and self-tested; the necessary allowlist entries cover YAML task/message values only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The review-history comment check now also flags work-package labels (
WP3-B,WP-E), handoff section references (handoff §5b) and finding codes (R3-7,R2b,P1-5,F2) that sit next to a review, round, gate or finding word. The marker list is identical in the five component repos.The new markers matched 176 lines. 128 are comments or docstrings and now keep their reason and drop the label. 48 are YAML task names and message strings, allowlisted with reasons because renaming them changes run output. Comments and docstrings only; no behavior changes.
The self-test plants one marker per pattern, which must fail, and a legitimate sentence per pattern (hex colours,
P95,R1, RFC and ADR numbers, HTTP codes, standalone§4.5), which must pass.Part of dmfdeploy/dmfdeploy#785
Refs dmfdeploy/dmfdeploy#785