Repository navigation
feat(observer): expose OpenBao AppRole rotation metrics - #17
Merged
Merged
Conversation
znerol2
added
hold
Contributor
Author
|
Status, 2026-11-06: unblocked. The #396 scheduler question is settled (in-cluster CronJob; see dmfdeploy/dmfdeploy#396). This draft needs a rebase onto |
Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
znerol2
force-pushed
the
feat/openbao-approle-observer-396
branch
from
November 6, 2026 11:36
f8c645e to
1a8a65b
Compare
…hronology Refs dmfdeploy/dmfdeploy#396 - Poll OpenBao outside the snapshot lock and publish a finished snapshot atomically, so a slow poll can't block /metrics or the other endpoints. - Build the HTTP client with the configured CA only. A missing, empty or invalid CA leaves the targets unavailable with collection_error=1, the service still starts, and the next poll retries. The client never falls back to the system trust store. - Reject records whose history contradicts the latest run: a timestamp newer than the latest run, a scheduled success newer than the last success, or a latest success missing from the success history. - An explicit latest scheduled failure always raises the failure flag, even when its time ties the last scheduled success. The HELP text says the flag is conservative, because the registry keeps one shared failure time and a manual failure also raises it. Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a metadata-only OpenBao AppRole lifecycle observer to dmf-promsd. It validates the configured CA, reads only the approved registry metadata, and exposes bounded lifecycle metrics for the monitoring stack.
Scope and readiness boundary
This is a source foundation for dmfdeploy/dmfdeploy#396 and dmfdeploy/dmfdeploy#11. It does not implement the credential rotation writer or scheduled CronJob, and it does not demonstrate a live scheduled heartbeat. The heartbeat metric reads the registry's
last_scheduled_success_at; the writer must update that value only after a complete successful scheduled sweep.The observer Kubernetes-auth role in dmf-infra#118 is provisioned only during fresh OpenBao initialization. Existing initialized environments require a separately reviewed privileged migration before the observer can authenticate. Do not treat this PR as rollout-ready for such environments; no auth-role management authority is added to the policy reconciler.
Verification
uv run --extra dev pytest tests/test_observer.py tests/test_settings.py tests/test_main.py -q: 32 passed.Refs dmfdeploy/dmfdeploy#396 and dmfdeploy/dmfdeploy#11.