Repository navigation
feat: gate bootstrap configure on setup receipt - #48
Merged
Merged
Conversation
Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
lkirc
requested changes
Oct 27, 2026
lkirc
left a comment
lkirc
left a comment
There was a problem hiding this comment.
Request changes: two blocking issues remain.
src/dmf_init/orchestrate.py:205: The receipt is put in the configure environment but never added withrun.add_secret(). Configure stdout/stderr is streamed throughrun.emit()and retained in error hints, so any task that echoes the receipt exposes it in bootstrap events, contrary to the stated requirement. Register it for redaction before invoking the executor and cover echoed success/failure output.src/dmf_init/bootstrap_steps.py:692: The new initial-passkey gate is enforced only by the browser. An authenticated caller can POST/api/bootstrap/resumeforinitial-passkey(even before the worker reaches it);BootstrapRun.resume()accepts any registered pause without a passkey-status check. Revalidate the passkey count and the active gate server-side before resuming, so configure cannot run without the required first passkey.
…ey on the server Register the setup request id for redaction before configure runs, so output that echoes it stays out of events and error hints. Check the live passkey count in the resume route for initial-passkey, and resume initial-passkey and setup-request only while the worker waits on them. A direct call can no longer run configure early or without the first passkey. Claude-Session: https://claude.ai/code/session_01Rq1iSvhmEwbNUF43rtXVY4 Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DMF_SETUP_REQUEST_IDin the configure process environment; keep the id out of argv, events, journal state, and recovery bundles.Dependencies
Verification
git diff --checkpassed.Refs dmfdeploy/dmfdeploy#11
Refs dmfdeploy/dmfdeploy#396