Repository navigation
fix(openbao): name the CA in the unseal wrapper's TLS guidance - #39
Merged
Merged
Conversation
The OpenBao pods now trust the CA that signs their listener certificate (ca.crt), not the certificate itself, and a renewed certificate reaches a running pod through the cert-manager play's reload instead of a restart. Update the wrapper's TLS comment and its exit-7 checklist to match. Refs dmfdeploy/dmfdeploy#879 Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
znerol2
added
the
hold
znerol2
removed
the
hold
Contributor
Author
|
dmfdeploy/dmf-infra#145 has merged, so the CA it introduces is now on main. Lifting the hold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to dmfdeploy/dmf-infra#145, which issues OpenBao's listener certificate from a CA. The pods then trust
ca.crt, and a renewed certificate reaches a running pod through the cert-manager play's reload instead of a restart.This updates
bin/unseal-openbao.shto match: the TLS comment, and the exit-7 checklist (BAO_CACERTnames the CA, default/openbao/config/tls/ca.crt, and the cert-manager play has run since the last renewal). Text only, no behaviour change.tests/unseal-openbao-tls.shpasses, and shellcheck is clean.Merge after dmfdeploy/dmf-infra#145.
Refs dmfdeploy/dmfdeploy#879