Repository navigation
docs(release): describe the provenance attestation instead of planned cosign signing - #217
Merged
Merged
Conversation
… cosign signing The build rules still said cosign signing was not wired and would gate pulls. Releases already carry a GitHub build-provenance attestation on the index digest, and nothing in the cluster checks signatures at pull time, so a cosign signature would add nothing yet. Say what exists, how to verify it, and that cosign and pull-time enforcement stay open for a lane that must refuse unverified images. Closes dmfdeploy/dmfdeploy#14 Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
lkirc
requested changes
Nov 9, 2026
lkirc
left a comment
There was a problem hiding this comment.
The new guidance overstates its coverage.
- docs/DEVELOPMENT-AND-BUILD-RULES.md:550: Scope this to releases published by the current attesting workflow (or document the first attested version).
v0.39.0predates.github/workflows/release.yml, so historical<VERSION>values do not have the workflow-created provenance attestation that the unqualified verification command promises.
…tation The verify command only works for releases the release workflow published. 0.40.1 is the first; 0.39.0 and earlier have no attestation. Refs dmfdeploy/dmfdeploy#14 Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
Contributor
Author
|
Thanks, good catch. Fixed in 0d8fe9f: the section now scopes the attestation to releases the release workflow published and names 0.40.1 as the first. I checked each release with |
lkirc
approved these changes
Nov 9, 2026
lkirc
left a comment
There was a problem hiding this comment.
Approved. The current head resolves the prior attestation-scope concern: it limits the guidance to workflow-published releases and documents 0.40.1 as the first attested release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/DEVELOPMENT-AND-BUILD-RULES.mdstill said cosign signing was "not yet wired" and would gate pulls. That's out of date.gh attestation verify.Decision (maintainer, 2026-11-08): the provenance attestation satisfies dmfdeploy/dmfdeploy#14 for now.
Check
gh attestation verify oci://ghcr.io/dmfdeploy/dmf-cms:0.41.0 --repo dmfdeploy/dmf-cmsexits 0.Closes dmfdeploy/dmfdeploy#14