Skip to content

docs(release): describe the provenance attestation instead of planned cosign signing - #217

Merged
dmf-cms-automerge[bot] merged 2 commits into
mainfrom
docs/14-provenance-not-cosign
Nov 9, 2026
Merged

dmf-cms-automerge[bot] merged 2 commits into
mainfrom
docs/14-provenance-not-cosign

Conversation

@znerol2

@znerol2 znerol2 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

docs/DEVELOPMENT-AND-BUILD-RULES.md still said cosign signing was "not yet wired" and would gate pulls. That's out of date.

  • Each release already carries a GitHub build-provenance attestation on its index digest, a signed record of the workflow, commit and repository that built it. The section now says so, and shows how to verify a release with gh attestation verify.
  • The cluster checks neither signatures nor attestations when it pulls an image, so a separate cosign signature would add nothing yet.
  • Cosign signing and a pull-time admission policy stay open as an option for a lane that must refuse unverified images.

Decision (maintainer, 2026-11-08): the provenance attestation satisfies dmfdeploy/dmfdeploy#14 for now.

Check

gh attestation verify oci://ghcr.io/dmfdeploy/dmf-cms:0.41.0 --repo dmfdeploy/dmf-cms exits 0.

Closes dmfdeploy/dmfdeploy#14

… cosign signing

The build rules still said cosign signing was not wired and would gate
pulls. Releases already carry a GitHub build-provenance attestation on
the index digest, and nothing in the cluster checks signatures at pull
time, so a cosign signature would add nothing yet. Say what exists, how
to verify it, and that cosign and pull-time enforcement stay open for a
lane that must refuse unverified images.

Closes dmfdeploy/dmfdeploy#14

Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
@znerol2
znerol2 requested a review from a team as a code owner November 9, 2026 07:04
@znerol2
znerol2 requested a review from lkirc November 9, 2026 07:04
@dmf-cms-automerge
dmf-cms-automerge Bot enabled auto-merge (rebase) November 9, 2026 07:10

@lkirc lkirc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new guidance overstates its coverage.

  • docs/DEVELOPMENT-AND-BUILD-RULES.md:550: Scope this to releases published by the current attesting workflow (or document the first attested version). v0.39.0 predates .github/workflows/release.yml, so historical <VERSION> values do not have the workflow-created provenance attestation that the unqualified verification command promises.

…tation

The verify command only works for releases the release workflow published.
0.40.1 is the first; 0.39.0 and earlier have no attestation.

Refs dmfdeploy/dmfdeploy#14

Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
@znerol2

znerol2 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, good catch. Fixed in 0d8fe9f: the section now scopes the attestation to releases the release workflow published and names 0.40.1 as the first. I checked each release with gh attestation verify: 0.38.0, 0.39.0 and 0.40.0 fail; 0.40.1, 0.40.2 and 0.41.0 pass.

@znerol2
znerol2 requested a review from lkirc November 9, 2026 08:29

@lkirc lkirc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The current head resolves the prior attestation-scope concern: it limits the guidance to workflow-published releases and documents 0.40.1 as the first attested release.

@dmf-cms-automerge
dmf-cms-automerge Bot merged commit 4df81c4 into main Nov 9, 2026
18 checks passed
@dmf-cms-automerge
dmf-cms-automerge Bot deleted the docs/14-provenance-not-cosign branch November 9, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cosign image signing for dmf-cms releases

2 participants